]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
arm64: dts: rockchip: Remove 'enable-active-low' from two boards
authorHeiko Stuebner <heiko@sntech.de>
Tue, 8 Oct 2024 20:39:35 +0000 (22:39 +0200)
committerHeiko Stuebner <heiko@sntech.de>
Fri, 25 Oct 2024 06:40:21 +0000 (08:40 +0200)
The 'enable-active-low' property is not a valid, because it is the
default behaviour of the fixed regulator.

Only 'enable-active-high' is valid, and when this property is absent
the fixed regulator will act as active low by default.

Both the rk3588-orange-pi-5 and the Wolfvision pf5 io expander overlay
smuggled those enable-active-low properties in, so remove them to
make dtbscheck happier.

Fixes: 28799a7734a0 ("arm64: dts: rockchip: add wolfvision pf5 io expander board")
Cc: Michael Riesch <michael.riesch@wolfvision.net>
Fixes: b6bc755d806e ("arm64: dts: rockchip: Add Orange Pi 5")
Cc: Muhammed Efe Cetin <efectn@6tel.net>
Reviewed-by: Michael Riesch <michael.riesch@wolfvision.net>
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20241008203940.2573684-10-heiko@sntech.de
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-io-expander.dtso
arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts

index ebcaeafc3800d04e885caa4b9a3d9388a61cce7d..fa61633aea15266dd1dee39e9034980845e5743c 100644 (file)
@@ -49,7 +49,6 @@
 
        vcc3v3_eth: vcc3v3-eth-regulator {
                compatible = "regulator-fixed";
-               enable-active-low;
                gpio = <&gpio0 RK_PC0 GPIO_ACTIVE_LOW>;
                pinctrl-names = "default";
                pinctrl-0 = <&vcc3v3_eth_enn>;
index c5ea07400276813db13bfc481b10e9d41d81b1d9..189fd9d838da6019102d4510151d806ea0519eb7 100644 (file)
 
        vcc_3v3_sd_s0: vcc-3v3-sd-s0-regulator {
                compatible = "regulator-fixed";
-               enable-active-low;
                gpios = <&gpio4 RK_PB5 GPIO_ACTIVE_LOW>;
                regulator-name = "vcc_3v3_sd_s0";
                regulator-boot-on;