]> git.ipfire.org Git - thirdparty/psycopg.git/commitdiff
ci: pin ast-comments to work around bug, document other bug as submitted
authorDaniele Varrazzo <daniele.varrazzo@gmail.com>
Mon, 2 Oct 2023 10:08:09 +0000 (12:08 +0200)
committerDaniele Varrazzo <daniele.varrazzo@gmail.com>
Wed, 11 Oct 2023 21:45:38 +0000 (23:45 +0200)
.github/workflows/lint.yml
tools/async_to_sync.py

index c8990a34f2e080958fc94ec65f0d2f4c028a9b78..484d605670632829abc80b3605310bc1212fb19f 100644 (file)
@@ -25,7 +25,10 @@ jobs:
           python-version: "3.10"
 
       - name: install packages to tests
-        run: pip install ./psycopg[dev,test] codespell ast-comments
+        # ast-comments version pinned beause of bug:
+        # https://github.com/t3rn0/ast-comments/issues/21
+        # TODO: unpin when fixed.
+        run: pip install ./psycopg[dev,test] codespell "ast-comments==1.1.0"
 
       - name: Run black
         run: black --check --diff .
index e0ba2260765a122ba4225475076a4e7af040cd29..782a7fa23e5096ebb8bab6373aeb20702f448250 100755 (executable)
@@ -13,13 +13,13 @@ from argparse import ArgumentParser, Namespace
 
 import ast_comments as ast
 
-# The ast_comment has an import:
+# ast_comment versions 1.1.0, 1.1.1 have an import:
 #
 #   from typing import Dict, List, Tuple, Union
 #
 # which shadows some of the types defined in ast.
 #
-# TODO: report the issue upstream
+# Reported in https://github.com/t3rn0/ast-comments/issues/22
 import ast as ast_orig
 
 ast.Dict = ast_orig.Dict