rec: Prevent a copy when distributing UDP queries to workers

Reported by Coverity as CID 1509301.

(cherry picked from commit 42d6b18e42e529a0ff89b57dca1043d6df4041ee)

diff --git a/pdns/recursordist/pdns_recursor.cc b/pdns/recursordist/pdns_recursor.cc
index 7d24f72a23c33972cc848a82f37b90a2db8bb8a5..41de6c479f9946ebaf0f51cd526a77ab285342a2 100644 (file)
--- a/pdns/recursordist/pdns_recursor.cc
+++ b/pdns/recursordist/pdns_recursor.cc
@@ -2519,7 +2519,7 @@ static void handleNewUDPQuestion(int fd, FDMultiplexer::funcparam_t& /* var */)
 
           if (RecThreadInfo::weDistributeQueries()) {
             std::string localdata = data;
-            distributeAsyncFunction(data, [localdata, fromaddr, dest, source, destination, mappedSource, tv, fd, proxyProtocolValues, eventTrace]() mutable {
+            distributeAsyncFunction(data, [localdata = std::move(localdata), fromaddr, dest, source, destination, mappedSource, tv, fd, proxyProtocolValues, eventTrace]() mutable {
               return doProcessUDPQuestion(localdata, fromaddr, dest, source, destination, mappedSource, tv, fd, proxyProtocolValues, eventTrace);
             });
           }