]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: dsa: b53: do not enable RGMII delay on bcm63xx
authorJonas Gorski <jonas.gorski@gmail.com>
Mon, 2 Jun 2025 19:39:50 +0000 (21:39 +0200)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 5 Jun 2025 09:07:35 +0000 (11:07 +0200)
bcm63xx's RGMII ports are always in MAC mode, never in PHY mode, so we
shouldn't enable any delays and let the PHY handle any delays as
necessary.

This fixes using RGMII ports with normal PHYs like BCM54612E, which will
handle the delay in the PHY.

Fixes: ce3bf94871f7 ("net: dsa: b53: add support for BCM63xx RGMIIs")
Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://patch.msgid.link/20250602193953.1010487-3-jonas.gorski@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/dsa/b53/b53_common.c

index 8a6a370c85808381b10f39c3695ddafbd2b3d9a4..c186ee3fb28df212aae8b1d3d547c8e6d89471d4 100644 (file)
@@ -1330,24 +1330,7 @@ static void b53_adjust_63xx_rgmii(struct dsa_switch *ds, int port,
                off = B53_RGMII_CTRL_P(port);
 
        b53_read8(dev, B53_CTRL_PAGE, off, &rgmii_ctrl);
-
-       switch (interface) {
-       case PHY_INTERFACE_MODE_RGMII_ID:
-               rgmii_ctrl |= (RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC);
-               break;
-       case PHY_INTERFACE_MODE_RGMII_RXID:
-               rgmii_ctrl &= ~(RGMII_CTRL_DLL_TXC);
-               rgmii_ctrl |= RGMII_CTRL_DLL_RXC;
-               break;
-       case PHY_INTERFACE_MODE_RGMII_TXID:
-               rgmii_ctrl &= ~(RGMII_CTRL_DLL_RXC);
-               rgmii_ctrl |= RGMII_CTRL_DLL_TXC;
-               break;
-       case PHY_INTERFACE_MODE_RGMII:
-       default:
-               rgmii_ctrl &= ~(RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC);
-               break;
-       }
+       rgmii_ctrl &= ~(RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC);
 
        if (port != dev->imp_port) {
                if (is63268(dev))