]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
global: io_remove*(NULL) is a no-op
authorJosef 'Jeff' Sipek <jeff.sipek@dovecot.fi>
Tue, 12 Dec 2017 16:10:15 +0000 (11:10 -0500)
committerAki Tuomi <aki.tuomi@open-xchange.com>
Wed, 13 Dec 2017 10:32:08 +0000 (12:32 +0200)
src/lib-ldap/ldap-connection.c
src/lib-master/master-service.c

index 1019072f909b0df120124f73f3a3bd2db514e745..6ac4c616737563bbf444d51d88455db9f2553445 100644 (file)
@@ -548,8 +548,7 @@ int ldap_connection_connect(struct ldap_connection *conn)
 
 void ldap_connection_kill(struct ldap_connection *conn)
 {
-       if (conn->io != NULL)
-               io_remove_closed(&(conn->io));
+       io_remove_closed(&(conn->io));
        timeout_remove(&(conn->to_disconnect));
        timeout_remove(&(conn->to_reconnect));
        if (conn->request_queue != NULL) {
index f45610e556aabb6ff388193c71de549741b27066..c2d689020696f27ed3fe7dd405b79c07645aa384 100644 (file)
@@ -1182,8 +1182,7 @@ void master_status_update(struct master_service *service)
            service->last_sent_status_avail_count) {
                /* a) closed, b) updating to same state */
                timeout_remove(&service->to_status);
-               if (service->io_status_write != NULL)
-                       io_remove(&service->io_status_write);
+               io_remove(&service->io_status_write);
                return;
        }
        if (ioloop_time == service->last_sent_status_time &&