simplehash: Free collisions array in SH_STAT

While SH_STAT() is only used for debugging, the allocated array can be large,
and therefore should be freed.

It's unclear why coverity started warning now.

Reported-by: Tom Lane <tgl@sss.pgh.pa.us>
Reported-by: Coverity
Discussion: https://postgr.es/m/3005248.1712538233@sss.pgh.pa.us
Backpatch: 12-

diff --git a/src/include/lib/simplehash.h b/src/include/lib/simplehash.h
index 145d9db50ec099c956e58d018505829eeea43354..6c3b96fd54920e3685f77496640f4504a8ce5f45 100644 (file)
--- a/src/include/lib/simplehash.h
+++ b/src/include/lib/simplehash.h
@@ -909,6 +909,9 @@ SH_STAT(SH_TYPE * tb)
                        max_collisions = curcoll;
        }
 
+       /* large enough to be worth freeing, even if just used for debugging */
+       pfree(collisions);
+
        if (tb->members > 0)
        {
                fillfactor = tb->members / ((double) tb->size);