]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
BUG/MINOR: peers: Possible appctx pointer dereference.
authorFrédéric Lécaille <flecaille@haproxy.com>
Sun, 17 Jan 2021 12:08:39 +0000 (13:08 +0100)
committerWilly Tarreau <w@1wt.eu>
Sun, 17 Jan 2021 20:58:03 +0000 (21:58 +0100)
This bug may occur when enabling peers traces. It is possible that
peer->appctx is NULL when entering peer_session_release().

src/peers.c

index e5b1e5714159da41bbf300b4c8240d62e377ab4a..754d73a8a84d43e359d7fe6623db19eef417047a 100644 (file)
@@ -425,7 +425,7 @@ static void peers_trace(enum trace_level level, uint64_t mask,
                        const struct peer *peer = a2;
                        struct peers *peers = NULL;
 
-                       if (peer) {
+                       if (peer && peer->appctx) {
                                struct stream_interface *si;
 
                                si = peer->appctx->owner;