]> git.ipfire.org Git - thirdparty/zstd.git/commitdiff
write the switch()case: differently
authorYann Collet <cyan@fb.com>
Wed, 5 Dec 2018 00:59:26 +0000 (16:59 -0800)
committerYann Collet <cyan@fb.com>
Wed, 5 Dec 2018 00:59:26 +0000 (16:59 -0800)
so that it please both
compilers which warn for dead code after the switch
and
compilers which do not detect that all branches terminate.

lib/decompress/zstd_decompress.c

index d2cd8a3024160cf5da2d91d667579ffcd75452b2..c4cd66c845b27f9a7100fa8531aa7ac13e7b2561 100644 (file)
@@ -1269,11 +1269,8 @@ ZSTD_bounds ZSTD_dParam_getBounds(ZSTD_dParameter dParam)
             bounds.upperBound = (int)ZSTD_f_zstd1_magicless;
             ZSTD_STATIC_ASSERT(ZSTD_f_zstd1 < ZSTD_f_zstd1_magicless);
             return bounds;
-        default:
-            bounds.error = ERROR(parameter_unsupported);
-            return bounds;
+        default:;
     }
-    assert(0);
     bounds.error = ERROR(parameter_unsupported);
     return bounds;
 }
@@ -1307,10 +1304,8 @@ size_t ZSTD_DCtx_setParameter(ZSTD_DCtx* dctx, ZSTD_dParameter dParam, int value
             CHECK_DBOUNDS(ZSTD_d_format, value);
             dctx->format = (ZSTD_format_e)value;
             return 0;
-        default:
-            return ERROR(parameter_unsupported);
+        default:;
     }
-    assert(0);  /* should be unreachable */
     return ERROR(parameter_unsupported);
 }