]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
soundwire: cadence_master: make frame index trace more readable
authorBard Liao <yung-chuan.liao@linux.intel.com>
Tue, 14 Oct 2025 03:14:44 +0000 (11:14 +0800)
committerVinod Koul <vkoul@kernel.org>
Mon, 8 Dec 2025 07:07:26 +0000 (12:37 +0530)
The existing code uses i as the frame index which is 0 based. And
"bad frame %d/%d", i, num_frames where num_frames is 1 based. Change the
frame index to i + 1 to align with num_frames and more readable.

Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://patch.msgid.link/20251014031450.3781789-2-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/cadence_master.c

index 21bb491d026b44bab68c67cfdb89dea6e74e6e9d..c59a98b408b3d0e067b8347936b778c50a1b0104 100644 (file)
@@ -2495,14 +2495,14 @@ int sdw_cdns_check_write_response(struct device *dev, u8 *dma_buffer,
                ret = check_frame_start(header, counter);
                if (ret < 0) {
                        dev_err(dev, "%s: bad frame %d/%d start header %x\n",
-                               __func__, i, num_frames, header);
+                               __func__, i + 1, num_frames, header);
                        return ret;
                }
 
                ret = check_frame_end(footer);
                if (ret < 0) {
                        dev_err(dev, "%s: bad frame %d/%d end footer %x\n",
-                               __func__, i, num_frames, footer);
+                               __func__, i + 1, num_frames, footer);
                        return ret;
                }
 
@@ -2573,7 +2573,7 @@ int sdw_cdns_check_read_response(struct device *dev, u8 *dma_buffer, int dma_buf
                ret = check_frame_start(header, counter);
                if (ret < 0) {
                        dev_err(dev, "%s: bad frame %d/%d start header %x\n",
-                               __func__, i, num_frames, header);
+                               __func__, i + 1, num_frames, header);
                        return ret;
                }
 
@@ -2588,7 +2588,7 @@ int sdw_cdns_check_read_response(struct device *dev, u8 *dma_buffer, int dma_buf
 
                if (crc != expected_crc) {
                        dev_err(dev, "%s: bad frame %d/%d crc %#x expected %#x\n",
-                               __func__, i, num_frames, crc, expected_crc);
+                               __func__, i + 1, num_frames, crc, expected_crc);
                        return -EIO;
                }
 
@@ -2599,7 +2599,7 @@ int sdw_cdns_check_read_response(struct device *dev, u8 *dma_buffer, int dma_buf
                ret = check_frame_end(footer);
                if (ret < 0) {
                        dev_err(dev, "%s: bad frame %d/%d end footer %x\n",
-                               __func__, i, num_frames, footer);
+                               __func__, i + 1, num_frames, footer);
                        return ret;
                }