aarch64: Avoid hidden symbols for memcpy/memmove into static binaries

The __GI_* symbol aliases for __memcpy_generic are unnecessary since
they're never used.  Add them only for libc.so to avoid PLT.  Maybe
some time in future we need to evaluate the relative cost of PLT vs
gains from multiarch memcpy implementations and take a call on whether
to drop this completely.

	* sysdeps/aarch64/multiarch/memcpy_generic.S (__GI_memcpy):
	Define only for libc.so.

diff --git a/ChangeLog b/ChangeLog
index a847985e44c813bc51547549376114bd8a450058..6ac924be247d00d7a6b607e0058a519dc4d0e1f5 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2017-12-04  Siddhesh Poyarekar  <siddhesh@sourceware.org>
+
+       * sysdeps/aarch64/multiarch/memcpy_generic.S (__GI_memcpy):
+       Define only for libc.so.
+
 2017-12-04  Stefan Liebler  <stli@linux.vnet.ibm.com>
 
        * sysdeps/unix/sysv/linux/s390/s390-64/sysdep.h

diff --git a/sysdeps/aarch64/multiarch/memcpy_generic.S b/sysdeps/aarch64/multiarch/memcpy_generic.S
index 041a77943d6d62f3d7950bbf5d8185a7b5db19bc..edb2e52626e5ad0ab8a1a8f323055e796b1957bb 100644 (file)
--- a/sysdeps/aarch64/multiarch/memcpy_generic.S
+++ b/sysdeps/aarch64/multiarch/memcpy_generic.S
@@ -33,9 +33,11 @@
 # undef libc_hidden_builtin_def
 # define libc_hidden_builtin_def(name)
 
+# ifdef SHARED
 /* It doesn't make sense to send libc-internal memcpy calls through a PLT. */
        .globl __GI_memcpy; __GI_memcpy = __memcpy_generic
        .globl __GI_memmove; __GI_memmove = __memmove_generic
+# endif
 
 #endif