]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
domain_conf: graphics: extract DBus formatting to separate function
authorPavel Hrdina <phrdina@redhat.com>
Thu, 6 Mar 2025 11:11:33 +0000 (12:11 +0100)
committerPavel Hrdina <phrdina@redhat.com>
Fri, 7 Mar 2025 13:01:27 +0000 (14:01 +0100)
virDomainGraphicsDefFormat function was way too long so split it into
separate functions for each graphics type.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/conf/domain_conf.c

index 85db84c49684591979d7bb5109ed5d9d01bd275f..4b9297a780821592d1f39dc547149ebe12f3df54 100644 (file)
@@ -26610,6 +26610,23 @@ virDomainGraphicsDefFormatEGLHeadless(virBuffer *childBuf,
                                  def->data.egl_headless.rendernode);
 }
 
+static void
+virDomainGraphicsDefFormatDBus(virBuffer *attrBuf,
+                               virBuffer *childBuf,
+                               virDomainGraphicsDef *def)
+{
+    if (def->data.dbus.p2p)
+        virBufferAddLit(attrBuf, " p2p='yes'");
+
+    if (def->data.dbus.address)
+        virBufferAsprintf(attrBuf, " address='%s'", def->data.dbus.address);
+
+    virDomainGraphicsDefFormatGL(childBuf, def->data.dbus.gl,
+                                 def->data.dbus.rendernode);
+
+    virDomainGraphicsDefFormatAudio(childBuf, def->data.dbus.audioId);
+}
+
 static int
 virDomainGraphicsDefFormat(virBuffer *buf,
                            virDomainGraphicsDef *def,
@@ -26656,18 +26673,9 @@ virDomainGraphicsDefFormat(virBuffer *buf,
         break;
 
     case VIR_DOMAIN_GRAPHICS_TYPE_DBUS:
-        if (def->data.dbus.p2p)
-            virBufferAddLit(&attrBuf, " p2p='yes'");
-        if (def->data.dbus.address)
-            virBufferAsprintf(&attrBuf, " address='%s'",
-                              def->data.dbus.address);
-
-        virDomainGraphicsDefFormatGL(&childBuf, def->data.dbus.gl,
-                                     def->data.dbus.rendernode);
-
-        virDomainGraphicsDefFormatAudio(&childBuf, def->data.dbus.audioId);
-
+        virDomainGraphicsDefFormatDBus(&attrBuf, &childBuf, def);
         break;
+
     case VIR_DOMAIN_GRAPHICS_TYPE_LAST:
         break;
     }