]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: stmmac: qcom-ethqos: remove unnecessary setting max_speed
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Sat, 12 Apr 2025 14:09:59 +0000 (15:09 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 15 Apr 2025 00:44:45 +0000 (17:44 -0700)
Phylink will already limit the MAC speed according to the interface,
so if 2500BASE-X is selected, the maximum speed will be 2.5G. It is,
therefore, not necessary to set a speed limit. Remove setting
plat_dat->max_speed from this glue driver.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/E1u3bYV-000EcQ-Cv@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c

index cd25aea3e48f3cfcc02c8dea3d65c4b0a2cdf3ac..e8d4925be21c9f243c10a9bdbc6e3b9c4ec7c734 100644 (file)
@@ -676,7 +676,6 @@ static void qcom_ethqos_speed_mode_2500(struct net_device *ndev, void *data)
 {
        struct stmmac_priv *priv = netdev_priv(ndev);
 
-       priv->plat->max_speed = 2500;
        priv->plat->phy_interface = PHY_INTERFACE_MODE_2500BASEX;
 }