]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pmdomain: rockchip: Simplify dropping OF node reference
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sun, 25 Aug 2024 18:31:16 +0000 (20:31 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Fri, 13 Sep 2024 10:52:13 +0000 (12:52 +0200)
Drop OF node reference immediately after using it in
syscon_node_to_regmap(), which is both simpler and typical/expected
code pattern.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20240825183116.102953-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/pmdomain/rockchip/pm-domains.c

index 538dde58d924292c1d3369b1d3a97df217cb4db6..66e473065b6bfbf8d1839a3f99f471fe3c4b2a35 100644 (file)
@@ -716,12 +716,11 @@ static int rockchip_pm_add_one_domain(struct rockchip_pmu *pmu,
                                goto err_unprepare_clocks;
                        }
                        pd->qos_regmap[j] = syscon_node_to_regmap(qos_node);
+                       of_node_put(qos_node);
                        if (IS_ERR(pd->qos_regmap[j])) {
                                error = -ENODEV;
-                               of_node_put(qos_node);
                                goto err_unprepare_clocks;
                        }
-                       of_node_put(qos_node);
                }
        }