]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
hfsplus: don't set REQ_SYNC for hfsplus_submit_bio()
authorJohannes Thumshirn <johannes.thumshirn@wdc.com>
Thu, 10 Jul 2025 06:35:53 +0000 (08:35 +0200)
committerViacheslav Dubeyko <slava@dubeyko.com>
Fri, 25 Jul 2025 22:20:06 +0000 (15:20 -0700)
hfsplus_submit_bio() called by hfsplus_sync_fs() uses bdev_virt_rw() which
in turn uses submit_bio_wait() to submit the BIO.

But submit_bio_wait() already sets the REQ_SYNC flag on the BIO so there
is no need for setting the flag in hfsplus_sync_fs() when calling
hfsplus_submit_bio().

Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Yangtao Li <frank.li@vivo.com>
Reviewed-by: Viacheslav Dubeyko <slava@dubeyko.com>
Signed-off-by: Viacheslav Dubeyko <slava@dubeyko.com>
Link: https://lore.kernel.org/r/20250710063553.4805-1-johannes.thumshirn@wdc.com
Link: https://lore.kernel.org/r/20250710063553.4805-1-johannes.thumshirn@wdc.com
Signed-off-by: Viacheslav Dubeyko <slava@dubeyko.com>
fs/hfsplus/super.c

index 948b8aaee33e3aa5822f3bf8adc9f0764405a445..8527e4ec406e63d9096fcb55ae812aaceb0b45c1 100644 (file)
@@ -222,8 +222,7 @@ static int hfsplus_sync_fs(struct super_block *sb, int wait)
 
        error2 = hfsplus_submit_bio(sb,
                                   sbi->part_start + HFSPLUS_VOLHEAD_SECTOR,
-                                  sbi->s_vhdr_buf, NULL, REQ_OP_WRITE |
-                                  REQ_SYNC);
+                                  sbi->s_vhdr_buf, NULL, REQ_OP_WRITE);
        if (!error)
                error = error2;
        if (!write_backup)
@@ -231,8 +230,7 @@ static int hfsplus_sync_fs(struct super_block *sb, int wait)
 
        error2 = hfsplus_submit_bio(sb,
                                  sbi->part_start + sbi->sect_count - 2,
-                                 sbi->s_backup_vhdr_buf, NULL, REQ_OP_WRITE |
-                                 REQ_SYNC);
+                                 sbi->s_backup_vhdr_buf, NULL, REQ_OP_WRITE);
        if (!error)
                error2 = error;
 out: