]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
BUG/MINOR: stream: Perform errors handling in right order in stream_new()
authorChristopher Faulet <cfaulet@haproxy.com>
Tue, 27 Sep 2022 07:14:47 +0000 (09:14 +0200)
committerChristopher Faulet <cfaulet@haproxy.com>
Tue, 27 Sep 2022 08:56:51 +0000 (10:56 +0200)
The frontend SC is attached before the backend one is allocated. Thus an
allocation error on backend SC must be handled before an error on the
frontend SC.

This patch must be backported to 2.6.

src/stream.c

index 8c7cdca7966f5387dc61ced3608b7bac495629d8..405992f8b79504eaa467ad47a55bd488ad57f094 100644 (file)
@@ -568,9 +568,9 @@ struct stream *stream_new(struct session *sess, struct stconn *sc, struct buffer
  out_fail_accept:
        flt_stream_release(s, 0);
        LIST_DELETE(&s->list);
- out_fail_attach_scf:
-       sc_free(s->scb);
  out_fail_alloc_scb:
+       sc_free(s->scb);
+ out_fail_attach_scf:
        task_destroy(t);
  out_fail_alloc:
        pool_free(pool_head_stream, s);