]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
xfs: remove impossible condition
authorLuis de Bethencourt <luisbg@osg.samsung.com>
Tue, 21 Jun 2016 05:56:25 +0000 (15:56 +1000)
committerDave Chinner <david@fromorbit.com>
Tue, 21 Jun 2016 05:56:25 +0000 (15:56 +1000)
Source kernel commit a5fd276bdc4fb71b06d100a6abc77ad682f77de4

bp_release is set to 0 just before the breakpoint of the for loop before
the conditional check (in line 458). The other breakpoint is a goto that
skips the dead code.

Addresses-Coverity-Id: 102338

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
difflibxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
index ef00156..9054c50 100644

libxfs/xfs_bmap.c

index c513e45680a06d9650f8fa18c5a355aad06eab3d..ec74ed876c083030b83dfd52afe969da2a398ac5 100644 (file)
@@ -469,10 +469,7 @@ xfs_bmap_check_leaf_extents(
                }
                block = XFS_BUF_TO_BLOCK(bp);
        }
-       if (bp_release) {
-               bp_release = 0;
-               xfs_trans_brelse(NULL, bp);
-       }
+
        return;
 
 error0: