]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virsh: Annotate '--diskspec' _ARGV options as unwanted positional
authorPeter Krempa <pkrempa@redhat.com>
Wed, 13 Mar 2024 21:44:44 +0000 (22:44 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 2 Apr 2024 12:24:29 +0000 (14:24 +0200)
Our documentation in most places explicitly mentions --diskspec and it
was never meant to be positional, although we can't change the parser
any more. Annotate them as 'unwanted_positional'.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
tools/virsh-checkpoint.c
tools/virsh-snapshot.c

index 869c07170099c29e3ca4c9e9bf467c9b50374583..65061cbf3d56b2943d384e8a5116848872815298 100644 (file)
@@ -206,6 +206,7 @@ static const vshCmdOptDef opts_checkpoint_create_as[] = {
     },
     {.name = "diskspec",
      .type = VSH_OT_ARGV,
+     .unwanted_positional = true,
      .help = N_("disk attributes: disk[,checkpoint=type][,bitmap=name]")
     },
     {.name = NULL}
index 899bae7e9abfc52a04284eb88b278b70f834339d..638333f4d6569d2b21c6937d6f7c92ae3fdec547 100644 (file)
@@ -361,6 +361,7 @@ static const vshCmdOptDef opts_snapshot_create_as[] = {
     },
     {.name = "diskspec",
      .type = VSH_OT_ARGV,
+     .unwanted_positional = true,
      .help = N_("disk attributes: disk[,snapshot=type][,driver=type][,stype=type][,file=name]")
     },
     {.name = NULL}