]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core.git/commitdiff
devtool: modify: Correct appending of type=git-dependency to URIs
authorPeter Kjellerstedt <peter.kjellerstedt@axis.com>
Thu, 15 Feb 2024 22:12:50 +0000 (23:12 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 16 Feb 2024 15:13:15 +0000 (15:13 +0000)
A missing space when using :append would lead to run-on URIs if there
was no whitespace at the end of the original SRC_URI.

Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
scripts/lib/devtool/standard.py

index 8fb4b934d438110eb1cde80885358a438b8e9679..0243e3bc7527793c1bf7c1af3e234576abd3db19 100644 (file)
@@ -966,7 +966,7 @@ def modify(args, config, basepath, workspace):
             # Assume first entry is main source extracted in ${S} so skip it
             src_uri = src_uri[1::]
 
-            #Add "type=git-dependency" to all non local sources
+            # Add "type=git-dependency" to all non local sources
             for url in src_uri:
                 if not url.startswith('file://') and not 'type=' in url:
                     src_uri_remove.append(url)
@@ -974,7 +974,7 @@ def modify(args, config, basepath, workspace):
 
             if src_uri_remove:
                 f.write('SRC_URI:remove = "%s"\n' % ' '.join(src_uri_remove))
-                f.write('SRC_URI:append = "%s"\n\n' % ' '.join(src_uri_append))
+                f.write('SRC_URI:append = " %s"\n\n' % ' '.join(src_uri_append))
 
             f.write('FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:"\n')
             # Local files can be modified/tracked in separate subdir under srctree