Silence compiler warnings from some older compilers.

Since a117cebd6, some older gcc versions issue "variable may be used
uninitialized in this function" complaints for brin_summarize_range.
Silence that using the same coding pattern as in bt_index_check_internal;
arguably, a117cebd6 had too narrow a view of which compilers might give
trouble.

Nathan Bossart and Tom Lane.  Back-patch as the previous commit was.

Discussion: https://postgr.es/m/20220601163537.GA2331988@nathanxps13

diff --git a/contrib/amcheck/verify_nbtree.c b/contrib/amcheck/verify_nbtree.c
index f23bc1473b0109a841ac953c270e0481988261c6..7f8231a6815dce0b18e948d982c3c7536f55df10 100644 (file)
--- a/contrib/amcheck/verify_nbtree.c
+++ b/contrib/amcheck/verify_nbtree.c
@@ -283,7 +283,7 @@ bt_index_check_internal(Oid indrelid, bool parentcheck, bool heapallindexed,
        else
        {
                heaprel = NULL;
-               /* for "gcc -Og" https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78394 */
+               /* Set these just to suppress "uninitialized variable" warnings */
                save_userid = InvalidOid;
                save_sec_context = -1;
                save_nestlevel = -1;

diff --git a/src/backend/access/brin/brin.c b/src/backend/access/brin/brin.c
index 685899fc24c1410f562d48e7d19bbce9c9eb145c..21a23842595f92d4c20947297a46787c53a38b92 100644 (file)
--- a/src/backend/access/brin/brin.c
+++ b/src/backend/access/brin/brin.c
@@ -1053,7 +1053,13 @@ brin_summarize_range(PG_FUNCTION_ARGS)
                save_nestlevel = NewGUCNestLevel();
        }
        else
+       {
                heapRel = NULL;
+               /* Set these just to suppress "uninitialized variable" warnings */
+               save_userid = InvalidOid;
+               save_sec_context = -1;
+               save_nestlevel = -1;
+       }
 
        indexRel = index_open(indexoid, ShareUpdateExclusiveLock);