]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
geneve: Convert geneve_exit_batch_rtnl() to ->exit_rtnl().
authorKuniyuki Iwashima <kuniyu@amazon.com>
Fri, 11 Apr 2025 20:52:42 +0000 (13:52 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 15 Apr 2025 00:08:44 +0000 (17:08 -0700)
geneve_exit_batch_rtnl() iterates the dying netns list and
performs the same operation for each.

Let's use ->exit_rtnl().

Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
Link: https://patch.msgid.link/20250411205258.63164-14-kuniyu@amazon.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/geneve.c

index 66e38ce9cd1d32444e97fb7fb175c28c48864214..ffc15a43268996f2a8924937e18caaadd59ec528 100644 (file)
@@ -1946,22 +1946,14 @@ static __net_init int geneve_init_net(struct net *net)
        return 0;
 }
 
-static void geneve_destroy_tunnels(struct net *net, struct list_head *head)
+static void __net_exit geneve_exit_rtnl_net(struct net *net,
+                                           struct list_head *dev_to_kill)
 {
        struct geneve_net *gn = net_generic(net, geneve_net_id);
        struct geneve_dev *geneve, *next;
 
        list_for_each_entry_safe(geneve, next, &gn->geneve_list, next)
-               geneve_dellink(geneve->dev, head);
-}
-
-static void __net_exit geneve_exit_batch_rtnl(struct list_head *net_list,
-                                             struct list_head *dev_to_kill)
-{
-       struct net *net;
-
-       list_for_each_entry(net, net_list, exit_list)
-               geneve_destroy_tunnels(net, dev_to_kill);
+               geneve_dellink(geneve->dev, dev_to_kill);
 }
 
 static void __net_exit geneve_exit_net(struct net *net)
@@ -1973,7 +1965,7 @@ static void __net_exit geneve_exit_net(struct net *net)
 
 static struct pernet_operations geneve_net_ops = {
        .init = geneve_init_net,
-       .exit_batch_rtnl = geneve_exit_batch_rtnl,
+       .exit_rtnl = geneve_exit_rtnl_net,
        .exit = geneve_exit_net,
        .id   = &geneve_net_id,
        .size = sizeof(struct geneve_net),