ata: pata_it821x: Replace deprecated strcpy with strscpy in it821x_display_disk

strcpy() is deprecated; use strscpy() instead.

Replace the hard-coded buffer size 8 with sizeof(mbuf) when using
snprintf() while we're at it.

Link: https://github.com/KSPP/linux/issues/88
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Signed-off-by: Niklas Cassel <cassel@kernel.org>

diff --git a/drivers/ata/pata_it821x.c b/drivers/ata/pata_it821x.c
index 042f6ad1f7c6910d34438a44139e6a4bb8b3d7ac..fc762dcc61bfd6dbc9a46706309b9c488430b17c 100644 (file)
--- a/drivers/ata/pata_it821x.c
+++ b/drivers/ata/pata_it821x.c
@@ -75,6 +75,7 @@
 #include <linux/blkdev.h>
 #include <linux/delay.h>
 #include <linux/slab.h>
+#include <linux/string.h>
 #include <scsi/scsi_host.h>
 #include <linux/libata.h>
 
@@ -632,9 +633,9 @@ static void it821x_display_disk(struct ata_port *ap, int n, u8 *buf)
                cbl = "";
 
        if (mode)
-               snprintf(mbuf, 8, "%5s%d", mtype, mode - 1);
+               snprintf(mbuf, sizeof(mbuf), "%5s%d", mtype, mode - 1);
        else
-               strcpy(mbuf, "PIO");
+               strscpy(mbuf, "PIO");
        if (buf[52] == 4)
                ata_port_info(ap, "%d: %-6s %-8s          %s %s\n",
                                n, mbuf, types[buf[52]], id, cbl);