]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/xe/guc: Move state change logger to helper
authorMichal Wajdeczko <michal.wajdeczko@intel.com>
Wed, 9 Jul 2025 17:40:37 +0000 (19:40 +0200)
committerMichal Wajdeczko <michal.wajdeczko@intel.com>
Thu, 10 Jul 2025 19:39:25 +0000 (21:39 +0200)
In the state change helper we are already doing extra stuff,
move debug state logger there to cover all state changes.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Acked-by: Matthew Brost <matthew.brost@intel.com>
Link: https://lore.kernel.org/r/20250709174038.1876-3-michal.wajdeczko@intel.com
drivers/gpu/drm/xe/xe_guc_ct.c

index 2a052dc22ff286d7fb2c76c0136f19fb159b59f6..17e5870baf339628851c076ec082220cbf14b38a 100644 (file)
@@ -387,6 +387,8 @@ static int guc_ct_control_toggle(struct xe_guc_ct *ct, bool enable)
 static void guc_ct_change_state(struct xe_guc_ct *ct,
                                enum xe_guc_ct_state state)
 {
+       struct xe_gt *gt = ct_to_gt(ct);
+
        mutex_lock(&ct->lock);          /* Serialise dequeue_one_g2h() */
        spin_lock_irq(&ct->fast_lock);  /* Serialise CT fast-path */
 
@@ -398,6 +400,10 @@ static void guc_ct_change_state(struct xe_guc_ct *ct,
        ct->g2h_outstanding = 0;
        ct->state = state;
 
+       xe_gt_dbg(gt, "GuC CT communication channel %s\n",
+                 state == XE_GUC_CT_STATE_STOPPED ? "stopped" :
+                 str_enabled_disabled(state == XE_GUC_CT_STATE_ENABLED));
+
        spin_unlock_irq(&ct->fast_lock);
 
        /*
@@ -473,7 +479,6 @@ int xe_guc_ct_enable(struct xe_guc_ct *ct)
 
        smp_mb();
        wake_up_all(&ct->wq);
-       xe_gt_dbg(gt, "GuC CT communication channel enabled\n");
 
        if (ct_needs_safe_mode(ct))
                ct_enter_safe_mode(ct);