fsnotify: fix merge with parent's ignored mask

fsnotify_parent() does not consider the parent's mark at all unless
the parent inode shows interest in events on children and in the
specific event.

So unless parent added an event to both its mark mask and ignored mask,
the event will not be ignored.

Fix this by declaring the interest of an object in an event when the
event is in either a mark mask or ignored mask.

Link: https://lore.kernel.org/r/20220223151438.790268-2-amir73il@gmail.com
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>

diff --git a/fs/notify/fanotify/fanotify_user.c b/fs/notify/fanotify/fanotify_user.c
index 2ff6bd85ba8f6abc70deaf9fd5192ef9cf2419b8..bd99430a128dc4d0fd28b75ae7ecf753d8322c44 100644 (file)
--- a/fs/notify/fanotify/fanotify_user.c
+++ b/fs/notify/fanotify/fanotify_user.c
@@ -1003,17 +1003,18 @@ static __u32 fanotify_mark_remove_from_mask(struct fsnotify_mark *fsn_mark,
                                            __u32 mask, unsigned int flags,
                                            __u32 umask, int *destroy)
 {
-       __u32 oldmask = 0;
+       __u32 oldmask, newmask;
 
        /* umask bits cannot be removed by user */
        mask &= ~umask;
        spin_lock(&fsn_mark->lock);
+       oldmask = fsnotify_calc_mask(fsn_mark);
        if (!(flags & FAN_MARK_IGNORED_MASK)) {
-               oldmask = fsn_mark->mask;
                fsn_mark->mask &= ~mask;
        } else {
                fsn_mark->ignored_mask &= ~mask;
        }
+       newmask = fsnotify_calc_mask(fsn_mark);
        /*
         * We need to keep the mark around even if remaining mask cannot
         * result in any events (e.g. mask == FAN_ONDIR) to support incremenal
@@ -1023,7 +1024,7 @@ static __u32 fanotify_mark_remove_from_mask(struct fsnotify_mark *fsn_mark,
        *destroy = !((fsn_mark->mask | fsn_mark->ignored_mask) & ~umask);
        spin_unlock(&fsn_mark->lock);
 
-       return mask & oldmask;
+       return oldmask & ~newmask;
 }
 
 static int fanotify_remove_mark(struct fsnotify_group *group,
@@ -1081,23 +1082,23 @@ static int fanotify_remove_inode_mark(struct fsnotify_group *group,
 }
 
 static __u32 fanotify_mark_add_to_mask(struct fsnotify_mark *fsn_mark,
-                                      __u32 mask,
-                                      unsigned int flags)
+                                      __u32 mask, unsigned int flags)
 {
-       __u32 oldmask = -1;
+       __u32 oldmask, newmask;
 
        spin_lock(&fsn_mark->lock);
+       oldmask = fsnotify_calc_mask(fsn_mark);
        if (!(flags & FAN_MARK_IGNORED_MASK)) {
-               oldmask = fsn_mark->mask;
                fsn_mark->mask |= mask;
        } else {
                fsn_mark->ignored_mask |= mask;
                if (flags & FAN_MARK_IGNORED_SURV_MODIFY)
                        fsn_mark->flags |= FSNOTIFY_MARK_FLAG_IGNORED_SURV_MODIFY;
        }
+       newmask = fsnotify_calc_mask(fsn_mark);
        spin_unlock(&fsn_mark->lock);
 
-       return mask & ~oldmask;
+       return newmask & ~oldmask;
 }
 
 static struct fsnotify_mark *fanotify_add_new_mark(struct fsnotify_group *group,

diff --git a/fs/notify/mark.c b/fs/notify/mark.c
index 9007d6affff359a1c8a74ee1755ab294b220f89d..4853184f7ddefd2a340ffe20391e8c6159258916 100644 (file)
--- a/fs/notify/mark.c
+++ b/fs/notify/mark.c
@@ -127,7 +127,7 @@ static void __fsnotify_recalc_mask(struct fsnotify_mark_connector *conn)
                return;
        hlist_for_each_entry(mark, &conn->list, obj_list) {
                if (mark->flags & FSNOTIFY_MARK_FLAG_ATTACHED)
-                       new_mask |= mark->mask;
+                       new_mask |= fsnotify_calc_mask(mark);
        }
        *fsnotify_conn_mask_p(conn) = new_mask;
 }
@@ -692,7 +692,7 @@ int fsnotify_add_mark_locked(struct fsnotify_mark *mark,
        if (ret)
                goto err;
 
-       if (mark->mask)
+       if (mark->mask || mark->ignored_mask)
                fsnotify_recalc_mask(mark->connector);
 
        return ret;

diff --git a/include/linux/fsnotify_backend.h b/include/linux/fsnotify_backend.h
index 790c31844db5dc969cad6dd494cc75e5fbbed238..5f9c960049b0761106cb1e8204dfcea2c8988f8e 100644 (file)
--- a/include/linux/fsnotify_backend.h
+++ b/include/linux/fsnotify_backend.h
@@ -601,6 +601,21 @@ extern void fsnotify_remove_queued_event(struct fsnotify_group *group,
 
 /* functions used to manipulate the marks attached to inodes */
 
+/* Get mask for calculating object interest taking ignored mask into account */
+static inline __u32 fsnotify_calc_mask(struct fsnotify_mark *mark)
+{
+       __u32 mask = mark->mask;
+
+       if (!mark->ignored_mask)
+               return mask;
+
+       /*
+        * If mark is interested in ignoring events on children, the object must
+        * show interest in those events for fsnotify_parent() to notice it.
+        */
+       return mask | (mark->ignored_mask & ALL_FSNOTIFY_EVENTS);
+}
+
 /* Get mask of events for a list of marks */
 extern __u32 fsnotify_conn_mask(struct fsnotify_mark_connector *conn);
 /* Calculate mask of events for a list of marks */