]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pinctrl: abx500: use new GPIO line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 8 Apr 2025 07:17:41 +0000 (09:17 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 15 Apr 2025 21:48:09 +0000 (23:48 +0200)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://lore.kernel.org/20250408-gpiochip-set-rv-pinctrl-part1-v1-4-c9d521d7c8c7@linaro.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/nomadik/pinctrl-abx500.c

index 8cd4ba5cf0bdae7a6ca9b0b289aec5ed40e8f9e0..2f55f83127cf59d618ddc759bbb345b1e65c163b 100644 (file)
@@ -167,14 +167,10 @@ out:
        return bit;
 }
 
-static void abx500_gpio_set(struct gpio_chip *chip, unsigned offset, int val)
+static int abx500_gpio_set(struct gpio_chip *chip, unsigned int offset,
+                          int val)
 {
-       struct abx500_pinctrl *pct = gpiochip_get_data(chip);
-       int ret;
-
-       ret = abx500_gpio_set_bits(chip, AB8500_GPIO_OUT1_REG, offset, val);
-       if (ret < 0)
-               dev_err(pct->dev, "%s write failed (%d)\n", __func__, ret);
+       return abx500_gpio_set_bits(chip, AB8500_GPIO_OUT1_REG, offset, val);
 }
 
 static int abx500_gpio_direction_output(struct gpio_chip *chip,
@@ -540,7 +536,7 @@ static const struct gpio_chip abx500gpio_chip = {
        .direction_input        = abx500_gpio_direction_input,
        .get                    = abx500_gpio_get,
        .direction_output       = abx500_gpio_direction_output,
-       .set                    = abx500_gpio_set,
+       .set_rv                 = abx500_gpio_set,
        .to_irq                 = abx500_gpio_to_irq,
        .dbg_show               = abx500_gpio_dbg_show,
 };