]> git.ipfire.org Git - thirdparty/openvpn.git/commitdiff
test_tls_crypt: Improve mock() usage to be more portable
authorFrank Lichtenheld <frank@lichtenheld.com>
Fri, 30 Jun 2023 12:39:08 +0000 (14:39 +0200)
committerGert Doering <gert@greenie.muc.de>
Sat, 1 Jul 2023 20:08:05 +0000 (22:08 +0200)
Use the casting variants of mock(). Using the mock_ptr_type
fixes an existing bug where test_tls_crypt.c couldn't
build in MinGW 32bit:

test_tls_crypt.c:127:27: error:
cast to pointer from integer of different size
[-Werror=int-to-pointer-cast]
  127 |     const char *pem_str = (const char *) mock();

Change-Id: I6c03313b8677fa07c07e718b1f85f7efd3c4dea8
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Arne Schwabe <arne@rfc2549.org>
Message-Id: <20230630123908.82588-1-frank@lichtenheld.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26796.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit e87e44f7bcdffc208292cce9d314e2e52a175026)

tests/unit_tests/openvpn/test_tls_crypt.c

index 19ae29cc676c575faab0ddd1c8e11176dd923148..8bbe6004c1f7178c4ff276a77fa57a6bb16ebdb3 100644 (file)
@@ -118,7 +118,7 @@ __wrap_buffer_write_file(const char *filename, const struct buffer *buf)
     check_expected(filename);
     check_expected(pem);
 
-    return mock();
+    return mock_type(bool);
 }
 
 struct buffer
@@ -126,7 +126,7 @@ __wrap_buffer_read_from_file(const char *filename, struct gc_arena *gc)
 {
     check_expected(filename);
 
-    const char *pem_str = (const char *) mock();
+    const char *pem_str = mock_ptr_type(const char *);
     struct buffer ret = alloc_buf_gc(strlen(pem_str) + 1, gc);
     buf_write(&ret, pem_str, strlen(pem_str) + 1);