]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: ath12k: Introduce check against zero for ahvif->key_cipher in ath12k_mac_op_tx()
authorAaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
Thu, 3 Apr 2025 08:22:07 +0000 (13:52 +0530)
committerJeff Johnson <jeff.johnson@oss.qualcomm.com>
Sat, 12 Apr 2025 04:19:28 +0000 (21:19 -0700)
Currently, ahvif->key_cipher is compared with the enum value
(WMI_CIPHER_NONE) inside ath12k_mac_op_tx(). However, ahvif->key_cipher is
set using the macro value WLAN_CIPHER_SUITE_XXXX which seems inconsistent.

To improve code consistency and readability, introduce check against zero
for ahvif->key_cipher instead of comparing it with the enum
(WMI_CIPHER_NONE).

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00209-QCAHKSWPL_SILICONZ-1

Signed-off-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
Link: https://patch.msgid.link/20250403082207.3323938-3-aaradhana.sahu@oss.qualcomm.com
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
drivers/net/wireless/ath/ath12k/mac.c

index 1bc8e81ad525d5d59dc0f150a71bce51fadeb8b0..af89e1a2d0235ae5cc3348769f27c1ee1bae2148 100644 (file)
@@ -7502,7 +7502,7 @@ static void ath12k_mac_op_tx(struct ieee80211_hw *hw,
                        skb_cb->link_id = link_id;
 
                        /* For open mode, skip peer find logic */
-                       if (unlikely(ahvif->key_cipher == WMI_CIPHER_NONE))
+                       if (unlikely(!ahvif->key_cipher))
                                goto skip_peer_find;
 
                        spin_lock_bh(&tmp_ar->ab->base_lock);