lsasrv: Simplify dcesrv_lsa_AddRemoveAccountRights()

Use dom_sid_string_buf, no need to talloc.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

diff --git a/source4/rpc_server/lsa/dcesrv_lsa.c b/source4/rpc_server/lsa/dcesrv_lsa.c
index 948e296eade963f59c2a5e551b2123336fac179e..d497117ea772d11975cfa5ea4bdb689ec1920f9d 100644 (file)
--- a/source4/rpc_server/lsa/dcesrv_lsa.c
+++ b/source4/rpc_server/lsa/dcesrv_lsa.c
@@ -3059,7 +3059,8 @@ static NTSTATUS dcesrv_lsa_AddRemoveAccountRights(struct dcesrv_call_state *dce_
 {
        struct auth_session_info *session_info =
                dcesrv_call_session_info(dce_call);
-       const char *sidstr, *sidndrstr;
+       struct dom_sid_buf sidbuf;
+       const char *sidndrstr = NULL;
        struct ldb_message *msg;
        struct ldb_message_element *el;
        int ret;
@@ -3084,13 +3085,7 @@ static NTSTATUS dcesrv_lsa_AddRemoveAccountRights(struct dcesrv_call_state *dce_
                return NT_STATUS_NO_MEMORY;
        }
 
-       sidstr = dom_sid_string(msg, sid);
-       if (sidstr == NULL) {
-               TALLOC_FREE(msg);
-               return NT_STATUS_NO_MEMORY;
-       }
-
-       dnstr = talloc_asprintf(msg, "sid=%s", sidstr);
+       dnstr = talloc_asprintf(msg, "sid=%s", dom_sid_str_buf(sid, &sidbuf));
        if (dnstr == NULL) {
                TALLOC_FREE(msg);
                return NT_STATUS_NO_MEMORY;