]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
bpf: Use ftrace_get_symaddr() for kprobe_multi probes
authorMasami Hiramatsu (Google) <mhiramat@kernel.org>
Tue, 31 Dec 2024 16:00:14 +0000 (01:00 +0900)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Mon, 13 Jan 2025 20:04:30 +0000 (15:04 -0500)
Add ftrace_get_entry_ip() which is only for ftrace based probes, and use
it for kprobe multi probes because they are based on fprobe which uses
ftrace instead of kprobes.

Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Florent Revest <revest@chromium.org>
Cc: Martin KaFai Lau <martin.lau@linux.dev>
Cc: bpf <bpf@vger.kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Alan Maguire <alan.maguire@oracle.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Link: https://lore.kernel.org/173566081414.878879.10631096557346094362.stgit@devnote2
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/bpf_trace.c

index 8633515593341dc7b4e94b12139218abf2d11744..9bfd52913a5bf83a8723931c7f5c14df5cc9718e 100644 (file)
@@ -2591,6 +2591,13 @@ static DEFINE_PER_CPU(struct pt_regs, bpf_kprobe_multi_pt_regs);
 #define bpf_kprobe_multi_pt_regs_ptr() (NULL)
 #endif
 
+static unsigned long ftrace_get_entry_ip(unsigned long fentry_ip)
+{
+       unsigned long ip = ftrace_get_symaddr(fentry_ip);
+
+       return ip ? : fentry_ip;
+}
+
 static int copy_user_syms(struct user_syms *us, unsigned long __user *usyms, u32 cnt)
 {
        unsigned long __user usymbol;
@@ -2829,7 +2836,8 @@ kprobe_multi_link_handler(struct fprobe *fp, unsigned long fentry_ip,
        int err;
 
        link = container_of(fp, struct bpf_kprobe_multi_link, fp);
-       err = kprobe_multi_link_prog_run(link, get_entry_ip(fentry_ip), fregs, false, data);
+       err = kprobe_multi_link_prog_run(link, ftrace_get_entry_ip(fentry_ip),
+                                        fregs, false, data);
        return is_kprobe_session(link->link.prog) ? err : 0;
 }
 
@@ -2841,7 +2849,8 @@ kprobe_multi_link_exit_handler(struct fprobe *fp, unsigned long fentry_ip,
        struct bpf_kprobe_multi_link *link;
 
        link = container_of(fp, struct bpf_kprobe_multi_link, fp);
-       kprobe_multi_link_prog_run(link, get_entry_ip(fentry_ip), fregs, true, data);
+       kprobe_multi_link_prog_run(link, ftrace_get_entry_ip(fentry_ip),
+                                  fregs, true, data);
 }
 
 static int symbols_cmp_r(const void *a, const void *b, const void *priv)