]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
quota: Fix error handling if quota_warning settings couldn't be looked up
authorTimo Sirainen <timo.sirainen@open-xchange.com>
Wed, 22 Jan 2025 20:30:21 +0000 (22:30 +0200)
committerAki Tuomi <aki.tuomi@open-xchange.com>
Wed, 12 Feb 2025 10:34:16 +0000 (12:34 +0200)
The error code path for some reason deinitialized the whole quota root,
which caused freed memory to be accessed later.

src/plugins/quota/quota.c

index 5997f5f84bd29c4fe5c70975a62cd891336ca2fa..81b10f50eb5c7252126af990e6d8a9c21d04b018 100644 (file)
@@ -174,7 +174,6 @@ static int quota_root_has_under_warnings(struct quota_root *root)
                                        &quota_root_setting_parser_info, 0,
                                        &set, &error) < 0) {
                        e_error(root->backend.event, "%s", error);
-                       quota_root_deinit(root);
                        return -1;
                }
                bool under = strcmp(set->quota_warning_threshold,