]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
dm-cache: remove pointless error check
authorDipendra Khadka <kdipendra88@gmail.com>
Sun, 22 Sep 2024 16:47:01 +0000 (16:47 +0000)
committerMikulas Patocka <mpatocka@redhat.com>
Thu, 26 Sep 2024 15:26:56 +0000 (17:26 +0200)
Smatch reported following:
'''
drivers/md/dm-cache-target.c:3204 parse_cblock_range() warn: sscanf doesn't return error codes
drivers/md/dm-cache-target.c:3217 parse_cblock_range() warn: sscanf doesn't return error codes
'''

Sscanf doesn't return negative values at all.

Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
drivers/md/dm-cache-target.c

index 17f0fab1e25496c22e8a69fb2db1174202db9a11..621be35c2b00f531f5a63da73710b07f880746fe 100644 (file)
@@ -3200,8 +3200,6 @@ static int parse_cblock_range(struct cache *cache, const char *str,
         * Try and parse form (ii) first.
         */
        r = sscanf(str, "%llu-%llu%c", &b, &e, &dummy);
-       if (r < 0)
-               return r;
 
        if (r == 2) {
                result->begin = to_cblock(b);
@@ -3213,8 +3211,6 @@ static int parse_cblock_range(struct cache *cache, const char *str,
         * That didn't work, try form (i).
         */
        r = sscanf(str, "%llu%c", &b, &dummy);
-       if (r < 0)
-               return r;
 
        if (r == 1) {
                result->begin = to_cblock(b);