]> git.ipfire.org Git - thirdparty/glibc.git/commitdiff
Revert "hppa: Drop 16-byte pthread lock alignment"
authorJohn David Anglin <danglin@gcc.gnu.org>
Thu, 6 Jul 2023 15:47:50 +0000 (15:47 +0000)
committerJohn David Anglin <danglin@gcc.gnu.org>
Thu, 6 Jul 2023 15:47:50 +0000 (15:47 +0000)
This change reverts commits c4468cd3995b4236ea886901109b194641132b08
and ab991a3d1b401ded6bd4f027352da8262b021a11.

sysdeps/hppa/nptl/bits/pthreadtypes-arch.h
sysdeps/hppa/nptl/bits/struct_rwlock.h

index c1a46d66d0f9fa1d403baed438328ab0a5a0c2eb..999195c5b06dd52462be80946e3d1f72f98a4c5b 100644 (file)
@@ -40,7 +40,7 @@
 #define __SIZEOF_PTHREAD_RWLOCK_T 64
 #define __SIZEOF_PTHREAD_RWLOCKATTR_T 8
 
-#define __LOCK_ALIGNMENT
+#define __LOCK_ALIGNMENT __attribute__ ((__aligned__(16)))
 #define __ONCE_ALIGNMENT
 
 #endif /* bits/pthreadtypes.h */
index f91460b7f84588b9511e5c39681b6872ddccbeab..e83b4aab5281ace4aad30bd79ebb62aef428f960 100644 (file)
@@ -25,14 +25,8 @@ struct __pthread_rwlock_arch_t
   /* In the old Linuxthreads pthread_rwlock_t, this is the
      start of the 4-word 16-byte aligned lock structure. The
      next four words are all set to 1 by the Linuxthreads
-     PTHREAD_RWLOCK_INITIALIZER. We ignore them in NPTL.
-
-     The 16-byte aligned lock structure is not needed for NPTL.
-     It causes some package builds to fail (e.g., protobuf) and
-     issues with dynamic memory allocation in C++ versions prior
-     to C++17. Removing it allows for more efficient allocators
-     and better compatibility with other architectures.  */
-  int __compat_padding[4];
+     PTHREAD_RWLOCK_INITIALIZER. We ignore them in NPTL.  */
+  int __compat_padding[4] __attribute__ ((__aligned__(16)));
   unsigned int __readers;
   unsigned int __writers;
   unsigned int __wrphase_futex;