]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
PCI: rockchip: Refactor rockchip_pcie_disable_clocks() signature
authorAnand Moon <linux.amoon@gmail.com>
Mon, 2 Dec 2024 15:11:44 +0000 (20:41 +0530)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Wed, 15 Jan 2025 18:24:12 +0000 (18:24 +0000)
Refactor rockchip_pcie_disable_clocks() to accept a struct rockchip_pcie
pointer instead of a void pointer thus improving type safety and code
readability by explicitly specifying the expected data type.

Link: https://lore.kernel.org/r/20241202151150.7393-4-linux.amoon@gmail.com
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
drivers/pci/controller/pcie-rockchip.c
drivers/pci/controller/pcie-rockchip.h

index 51798e5128d38b0bab66ae61899aff369e087943..0f88da3788054ed35c11f38e4545c1c2994c17aa 100644 (file)
@@ -270,9 +270,8 @@ int rockchip_pcie_enable_clocks(struct rockchip_pcie *rockchip)
 }
 EXPORT_SYMBOL_GPL(rockchip_pcie_enable_clocks);
 
-void rockchip_pcie_disable_clocks(void *data)
+void rockchip_pcie_disable_clocks(struct rockchip_pcie *rockchip)
 {
-       struct rockchip_pcie *rockchip = data;
 
        clk_bulk_disable_unprepare(rockchip->num_clks, rockchip->clks);
 }
index 87041ed88b381e6b2701735efec588f00458a91b..11def598534b2f764f290032d8e3abd72d8d4e72 100644 (file)
@@ -369,7 +369,7 @@ int rockchip_pcie_init_port(struct rockchip_pcie *rockchip);
 int rockchip_pcie_get_phys(struct rockchip_pcie *rockchip);
 void rockchip_pcie_deinit_phys(struct rockchip_pcie *rockchip);
 int rockchip_pcie_enable_clocks(struct rockchip_pcie *rockchip);
-void rockchip_pcie_disable_clocks(void *data);
+void rockchip_pcie_disable_clocks(struct rockchip_pcie *rockchip);
 void rockchip_pcie_cfg_configuration_accesses(
                struct rockchip_pcie *rockchip, u32 type);