]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: sun3: Mark driver struct with __refdata to prevent section mismatch
authorGeert Uytterhoeven <geert@linux-m68k.org>
Tue, 5 Nov 2024 18:36:31 +0000 (19:36 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 7 Nov 2024 02:06:44 +0000 (21:06 -0500)
As described in the added code comment, a reference to .exit.text is ok
for drivers registered via module_platform_driver_probe().  Make this
explicit to prevent the following section mismatch warnings

    WARNING: modpost: drivers/scsi/sun3_scsi: section mismatch in reference: sun3_scsi_driver+0x4 (section: .data) -> sun3_scsi_remove (section: .exit.text)
    WARNING: modpost: drivers/scsi/sun3_scsi_vme: section mismatch in reference: sun3_scsi_driver+0x4 (section: .data) -> sun3_scsi_remove (section: .exit.text)

that trigger on a Sun 3 allmodconfig build.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Link: https://lore.kernel.org/r/b2c56fa3556505befe9b4cb9a830d9e2a962e72c.1730831769.git.geert@linux-m68k.org
Acked-by: Finn Thain <fthain@linux-m68k.org>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sun3_scsi.c

index bb47274d920dc773f4e789edf4a6af6482da1e01..ca9cd691cc324ddc3ee49430843934e7580b9c92 100644 (file)
@@ -656,7 +656,13 @@ static void __exit sun3_scsi_remove(struct platform_device *pdev)
        iounmap(ioaddr);
 }
 
-static struct platform_driver sun3_scsi_driver = {
+/*
+ * sun3_scsi_remove() lives in .exit.text. For drivers registered via
+ * module_platform_driver_probe() this is ok because they cannot get unbound at
+ * runtime. So mark the driver struct with __refdata to prevent modpost
+ * triggering a section mismatch warning.
+ */
+static struct platform_driver sun3_scsi_driver __refdata = {
        .remove = __exit_p(sun3_scsi_remove),
        .driver = {
                .name   = DRV_MODULE_NAME,