t2018: improve style of if-statement

Convert `[]` to `test` and break if-then into separate lines, both of
which bring the style in line with Git's coding guidelines.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/t2018-checkout-branch.sh b/t/t2018-checkout-branch.sh
index 79b16e46773011c11029ddc3751cf8f3f19b9a74..61206a90fb485e181664451abe72d9c3f0db687d 100755 (executable)
--- a/t/t2018-checkout-branch.sh
+++ b/t/t2018-checkout-branch.sh
@@ -20,7 +20,8 @@ do_checkout () {
        exp_sha=${2:-$(git rev-parse --verify HEAD)} &&
 
        # default options for git checkout: -b
-       if [ -z "$3" ]; then
+       if test -z "$3"
+       then
                opts="-b"
        else
                opts="$3"