]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ath9k_htc: Use appropriate rs_datalen type
authorMasashi Honma <masashi.honma@gmail.com>
Sat, 8 Aug 2020 23:32:58 +0000 (08:32 +0900)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 17 Aug 2020 10:23:28 +0000 (13:23 +0300)
kernel test robot says:
drivers/net/wireless/ath/ath9k/htc_drv_txrx.c:987:20: sparse: warning: incorrect type in assignment (different base types)
drivers/net/wireless/ath/ath9k/htc_drv_txrx.c:987:20: sparse:    expected restricted __be16 [usertype] rs_datalen
drivers/net/wireless/ath/ath9k/htc_drv_txrx.c:987:20: sparse:    got unsigned short [usertype]
drivers/net/wireless/ath/ath9k/htc_drv_txrx.c:988:13: sparse: warning: restricted __be16 degrades to integer
drivers/net/wireless/ath/ath9k/htc_drv_txrx.c:1001:13: sparse: warning: restricted __be16 degrades to integer

Indeed rs_datalen has host byte order, so modify it's own type.

Reported-by: kernel test robot <lkp@intel.com>
Fixes: cd486e627e67 ("ath9k_htc: Discard undersized packets")
Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200808233258.4596-1-masashi.honma@gmail.com
drivers/net/wireless/ath/ath9k/htc_drv_txrx.c

index b353995bdd45741fd6d720efc47260f4bbaa7795..f4c2a8d83f50dbef7a4ef67a43582ce2915cf1d1 100644 (file)
@@ -974,7 +974,7 @@ static bool ath9k_rx_prepare(struct ath9k_htc_priv *priv,
        struct ath_htc_rx_status *rxstatus;
        struct ath_rx_status rx_stats;
        bool decrypt_error = false;
-       __be16 rs_datalen;
+       u16 rs_datalen;
        bool is_phyerr;
 
        if (skb->len < HTC_RX_FRAME_HEADER_SIZE) {