]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mmc: renesas_sdhi: Switch to SYSTEM_SLEEP_PM_OPS()/RUNTIME_PM_OPS() and pm_ptr()
authorClaudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Mon, 17 Nov 2025 10:12:41 +0000 (12:12 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 18 Nov 2025 15:28:54 +0000 (16:28 +0100)
SET_SYSTEM_SLEEP_PM_OPS() and SET_RUNTIME_PM_OPS() require __maybe_unused
or #ifdefs protection against unused function warnings. The usage of
pm_ptr() and SYSTEM_SLEEP_PM_OPS()/RUNTIME_PM_OPS() allows the compiler to
see the functions, thus suppressing the warning. Drop the #ifdefs.

Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/renesas_sdhi_internal_dmac.c
drivers/mmc/host/tmio_mmc.h

index 73c84fd8a2d809819216147a12c00d356c70c9f8..ef06c3a60ae8900e719f7ecded01e2b93faac7c8 100644 (file)
@@ -600,18 +600,17 @@ static int renesas_sdhi_internal_dmac_probe(struct platform_device *pdev)
 }
 
 static const struct dev_pm_ops renesas_sdhi_internal_dmac_dev_pm_ops = {
-       SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
-                               pm_runtime_force_resume)
-       SET_RUNTIME_PM_OPS(tmio_mmc_host_runtime_suspend,
-                          tmio_mmc_host_runtime_resume,
-                          NULL)
+       SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume)
+       RUNTIME_PM_OPS(tmio_mmc_host_runtime_suspend,
+                      tmio_mmc_host_runtime_resume,
+                      NULL)
 };
 
 static struct platform_driver renesas_internal_dmac_sdhi_driver = {
        .driver         = {
                .name   = "renesas_sdhi_internal_dmac",
                .probe_type = PROBE_PREFER_ASYNCHRONOUS,
-               .pm     = &renesas_sdhi_internal_dmac_dev_pm_ops,
+               .pm     = pm_ptr(&renesas_sdhi_internal_dmac_dev_pm_ops),
                .of_match_table = renesas_sdhi_internal_dmac_of_match,
        },
        .probe          = renesas_sdhi_internal_dmac_probe,
index c8cdb1c0722e7bf2c37cedaa97718307de0ea659..b9de03325c587b38554880c61b9337221fd7374e 100644 (file)
@@ -209,10 +209,8 @@ void tmio_mmc_enable_mmc_irqs(struct tmio_mmc_host *host, u32 i);
 void tmio_mmc_disable_mmc_irqs(struct tmio_mmc_host *host, u32 i);
 irqreturn_t tmio_mmc_irq(int irq, void *devid);
 
-#ifdef CONFIG_PM
 int tmio_mmc_host_runtime_suspend(struct device *dev);
 int tmio_mmc_host_runtime_resume(struct device *dev);
-#endif
 
 static inline u16 sd_ctrl_read16(struct tmio_mmc_host *host, int addr)
 {