lib-smtp: server: Fix segfault occurring when XCLIENT command is handled.

Occurs only when the application (in this case LMTP) has a
conn_proxy_data_updated() callback. The context parameter was the struct
smtp_server_connection object itself, rather than the application context. This
caused the connection object to be overwritten.

diff --git a/src/lib-smtp/smtp-server-connection.c b/src/lib-smtp/smtp-server-connection.c
index daeba08ce6b9ff56514a16b81738442e908a5563..bf241d851f9ae11c9b4ed08ad06f7de3b41f0b51 100644 (file)
--- a/src/lib-smtp/smtp-server-connection.c
+++ b/src/lib-smtp/smtp-server-connection.c
@@ -1405,8 +1405,10 @@ void smtp_server_connection_set_proxy_data(struct smtp_server_connection *conn,
                conn->proxy_timeout_secs = proxy_data->timeout_secs;
 
        if (conn->callbacks != NULL &&
-               conn->callbacks->conn_proxy_data_updated != NULL)
-               conn->callbacks->conn_proxy_data_updated(conn, proxy_data);
+               conn->callbacks->conn_proxy_data_updated != NULL) {
+               conn->callbacks->
+                       conn_proxy_data_updated(conn->context, proxy_data);
+       }
 }
 
 void smtp_server_connection_switch_ioloop(struct smtp_server_connection *conn)