lib/krb5_wrap: Fix missing error check in new salt code

CID 1492905: Control flow issues  (DEADCODE)

This was a regression in 5eeb441b771a1ffe1ba1c69b72e8795f525a58ed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14874

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Oct 23 08:07:13 UTC 2021 on sn-devel-184

diff --git a/lib/krb5_wrap/krb5_samba.c b/lib/krb5_wrap/krb5_samba.c
index 63a6e951f80dcc1d3d27fa086a71944861d9dee3..fff5b4e2a22fcd7ff57058fa615219134bf72ad7 100644 (file)
--- a/lib/krb5_wrap/krb5_samba.c
+++ b/lib/krb5_wrap/krb5_samba.c
@@ -594,9 +594,9 @@ int smb_krb5_salt_principal(krb5_context krb5_ctx,
                 * No matter what realm (including none) in the UPN,
                 * the realm is replaced with our upper-case realm
                 */
-               smb_krb5_principal_set_realm(krb5_ctx,
-                                            *salt_princ,
-                                            upper_realm);
+               krb5_ret = smb_krb5_principal_set_realm(krb5_ctx,
+                                                       *salt_princ,
+                                                       upper_realm);
                if (krb5_ret != 0) {
                        krb5_free_principal(krb5_ctx, *salt_princ);
                        TALLOC_FREE(frame);