]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
cpuidle: governors: teo: Fix tick_intercepts handling in teo_update()
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Sun, 16 Nov 2025 12:34:29 +0000 (13:34 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 20 Nov 2025 13:54:08 +0000 (14:54 +0100)
The condition deciding whether or not to increase cpu_data->tick_intercepts
in teo_update() is reverse, so fix it.

Fixes: d619b5cc6780 ("cpuidle: teo: Simplify counting events used for tick management")
Cc: 6.14+ <stable@vger.kernel.org> # 6.14+: 0796ddf4a7f0: cpuidle: teo: Use this_cpu_ptr() where possible
Cc: 6.14+ <stable@vger.kernel.org> # 6.14+: 8f3f01082d7a: cpuidle: governors: teo: Use s64 consistently in teo_update()
Cc: 6.14+ <stable@vger.kernel.org> # 6.14+: b54df61c7428: cpuidle: governors: teo: Decay metrics below DECAY_SHIFT threshold
Cc: 6.14+ <stable@vger.kernel.org> 6.14+: 083654ded547: cpuidle: governors: teo: Rework the handling of tick wakeups
Cc: 6.14+ <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Christian Loehle <christian.loehle@arm.com>
Link: https://patch.msgid.link/5085160.31r3eYUQgx@rafael.j.wysocki
drivers/cpuidle/governors/teo.c

index 94ba00b7617d731613203c83863806f13d762f07..85b5517067d16514b1b64eb0fb387f76acff7389 100644 (file)
@@ -251,7 +251,7 @@ static void teo_update(struct cpuidle_driver *drv, struct cpuidle_device *dev)
                cpu_data->state_bins[idx_timer].hits += PULSE;
        } else {
                cpu_data->state_bins[idx_duration].intercepts += PULSE;
-               if (TICK_NSEC <= measured_ns)
+               if (measured_ns <= TICK_NSEC)
                        cpu_data->tick_intercepts += PULSE;
        }
 }