]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
io_uring: revert "io_uring fix multishot accept ordering"
authorDylan Yudaken <dylany@meta.com>
Mon, 21 Nov 2022 14:43:42 +0000 (07:43 -0700)
committerJens Axboe <axboe@kernel.dk>
Mon, 21 Nov 2022 14:43:42 +0000 (07:43 -0700)
This is no longer needed after commit aa1df3a360a0 ("io_uring: fix CQE
reordering"), since all reordering is now taken care of.

This reverts commit cbd25748545c ("io_uring: fix multishot accept
ordering").

Signed-off-by: Dylan Yudaken <dylany@meta.com>
Link: https://lore.kernel.org/r/20221107125236.260132-2-dylany@meta.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring/net.c

index f32e0daeedd81183498889d90a0a02d80eb516a6..f7b2b068464d011ae742a9d7c1c2be12f4daf38d 100644 (file)
@@ -1322,12 +1322,12 @@ retry:
                return IOU_OK;
        }
 
-       if (ret >= 0 &&
-           io_post_aux_cqe(ctx, req->cqe.user_data, ret, IORING_CQE_F_MORE, false))
+       if (ret < 0)
+               return ret;
+       if (io_post_aux_cqe(ctx, req->cqe.user_data, ret, IORING_CQE_F_MORE, true))
                goto retry;
 
-       io_req_set_res(req, ret, 0);
-       return (issue_flags & IO_URING_F_MULTISHOT) ? IOU_STOP_MULTISHOT : IOU_OK;
+       return -ECANCELED;
 }
 
 int io_socket_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)