]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
tests: don't fail with newer gnutls
authorMartin Kletzander <mkletzan@redhat.com>
Fri, 2 May 2014 07:55:52 +0000 (09:55 +0200)
committerEric Blake <eblake@redhat.com>
Thu, 22 Jan 2015 22:56:26 +0000 (15:56 -0700)
gnutls-3.3.0 and newer leaves 2 FDs open in order to be backwards
compatible when it comes to chrooted binaries [1].  Linking
commandhelper with gnutls then leaves these two FDs open and
commandtest fails thanks to that.  This patch does not link
commandhelper with libvirt.la, but rather only the utilities making
the test pass.

Based on suggestion from Daniel [2].

[1] http://lists.gnutls.org/pipermail/gnutls-help/2014-April/003429.html
[2] https://www.redhat.com/archives/libvir-list/2014-April/msg01119.html

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
(cherry picked from commit 4cbc15d037e1cd8abf5c4aa6acc30d83ae13e34d)

Conflicts:
tests/Makefile.am - missing commit 25527ae2 for GNULIB_LIBS

tests/Makefile.am

index 087e7be87dc0c7316648c2488e5c60be43666846..e9f52e692889bace24c315a6d307f1609b8568c1 100644 (file)
@@ -48,6 +48,9 @@ if WITH_DTRACE_PROBES
 PROBES_O += ../src/libvirt_probes.lo
 endif
 
+GNULIB_LIBS = \
+       ../gnulib/lib/libgnu.la
+
 LDADDS = \
         $(WARN_CFLAGS) \
        $(PROBES_O) \
@@ -550,7 +553,13 @@ commandtest_LDADD = $(LDADDS)
 
 commandhelper_SOURCES = \
        commandhelper.c
-commandhelper_LDADD = $(LDADDS)
+commandhelper_LDADD = \
+       $(WARN_CFLAGS) \
+       $(NO_INDIRECT_LDFLAGS) \
+       $(PROBES_O) \
+       ../src/libvirt_util.la \
+       $(GNULIB_LIBS)
+
 commandhelper_LDFLAGS = -static
 
 if WITH_LIBVIRTD