]> git.ipfire.org Git - pakfire.git/commitdiff
log stream: Don't fail if no callback has been registered
authorMichael Tremer <michael.tremer@ipfire.org>
Tue, 25 Mar 2025 11:09:35 +0000 (11:09 +0000)
committerMichael Tremer <michael.tremer@ipfire.org>
Tue, 25 Mar 2025 11:09:35 +0000 (11:09 +0000)
This should usually never happen.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
src/pakfire/log_stream.c

index d6abc24d08b567d60a4684ad367f9b94af415a43..7cb8f12f50d6676a8a571314f21674ba5eef9bba 100644 (file)
@@ -27,6 +27,7 @@
 #include <pakfire/buffer.h>
 #include <pakfire/ctx.h>
 #include <pakfire/log_stream.h>
+#include <pakfire/util.h>
 
 #define MAX_LINE_LENGTH 16384
 
@@ -243,9 +244,9 @@ static int pakfire_log_stream_drain_buffer(struct pakfire_log_stream* stream) {
        int r;
 
        // Log a message if we don't have a callback
-       if (!stream->callback) {
-               ERROR(stream->ctx, "Log stream has no callback set\n");
-               return -EINVAL;
+       if (unlikely(!stream->callback)) {
+               DEBUG(stream->ctx, "Log stream has no callback set\n");
+               return 0;
        }
 
        for (;;) {