]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
resolve: initialize `r` during OOM
authorFrantisek Sumsal <frantisek@sumsal.cz>
Thu, 4 Jan 2024 15:48:10 +0000 (16:48 +0100)
committerFrantisek Sumsal <frantisek@sumsal.cz>
Thu, 4 Jan 2024 19:56:21 +0000 (20:56 +0100)
Otherwise we'd use some garbage value in the error path.

../src/resolve/resolved-dns-query.c: In function ‘dns_query_accept’:
../src/resolve/resolved-dns-query.c:944:27: error: ‘r’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  944 |         q->answer_errno = -r;
      |                           ^~
cc1: all warnings being treated as errors

Follow-up for 9ca133e97a0.

src/resolve/resolved-dns-query.c

index d94fe1da997e4a7428483214a4a60e670459dcbe..a7bc45838f74ceee05b2ff00eccd664d54b31dcb 100644 (file)
@@ -902,7 +902,7 @@ static void dns_query_accept(DnsQuery *q, DnsQueryCandidate *c) {
                         if (t->answer_ede_msg) {
                                 answer_ede_msg = strdup(t->answer_ede_msg);
                                 if (!answer_ede_msg) {
-                                        log_oom();
+                                        r = log_oom();
                                         goto fail;
                                 }
                         }