]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ASoC: wm_adsp: Correct algorithm list allocation size
authorCharles Keepax <ckeepax@opensource.cirrus.com>
Thu, 19 Jul 2018 10:50:35 +0000 (11:50 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 19 Jul 2018 14:11:53 +0000 (15:11 +0100)
Commit 6396bb221514 ("treewide: kzalloc() -> kcalloc()") was
overlooked when doing some refactoring to the algorithm list
handling, which lead to twice as much buffer being allocated
as required for reading the algorithm list. A kcalloc is no
longer appropriate since the allocation size is now in bytes
not registers, as such change back to kzalloc.

Fixes: 7f7cca08abf4 ("ASoC: wm_adsp: Simplify handling of alg offset and length")
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm_adsp.c

index 07c17acc8a4fb06b11b35c0ea7535068f7afa9e2..99108d18de8d88388520b1c8d5a4b2e60a89e208 100644 (file)
@@ -1906,7 +1906,7 @@ static void *wm_adsp_read_algs(struct wm_adsp *dsp, size_t n_algs,
        /* Convert length from DSP words to bytes */
        len *= sizeof(u32);
 
-       alg = kcalloc(len, 2, GFP_KERNEL | GFP_DMA);
+       alg = kzalloc(len, GFP_KERNEL | GFP_DMA);
        if (!alg)
                return ERR_PTR(-ENOMEM);