]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: remove nonsensical sanity check in processNetdevStreamDisconnectedEvent()
authorLaine Stump <laine@redhat.com>
Fri, 4 Apr 2025 20:48:23 +0000 (16:48 -0400)
committerLaine Stump <laine@redhat.com>
Fri, 11 Apr 2025 03:47:16 +0000 (23:47 -0400)
By definition QEMU will never send a NETDEV_STREAM_DISCONNECTED event
if it doesn't support the reconnect option for a stream netdev. And
even if, by some comedy of errors, it did send
NETDEV_STREAM_DISCONNECTED in that case, our response to the event
doesn't request anything at all of QEMU (much less something that
would fail if QEMU didn't understand NETDEV_STREAM_DISCONNECTED) - it
just starts a new passt process to replace the one that has been
terminated, so we don't need to check the QEMU capabilities for
QEMU_CAPS_NETDEV_STREAM_RECONNECT.

Signed-off-by: Laine Stump <laine@redhat.com>
Tested-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_driver.c

index 3e48da080a294546d60e33758db8c70753a5d964..589778eaed50a3728c0b79727044d9809e27bce0 100644 (file)
@@ -3612,7 +3612,6 @@ processNetdevStreamDisconnectedEvent(virDomainObj *vm,
 {
     virDomainDeviceDef dev;
     virDomainNetDef *def;
-    virQEMUCaps *qemuCaps = QEMU_DOMAIN_PRIVATE(vm)->qemuCaps;
     const char *devAlias = STRSKIP(netdevId, "host");
 
     /* The event sends us the "netdev-id", but we don't store the
@@ -3658,12 +3657,6 @@ processNetdevStreamDisconnectedEvent(virDomainObj *vm,
         goto endjob;
     }
 
-    if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_NETDEV_STREAM_RECONNECT)) {
-        VIR_WARN("ignore NETDEV_STREAM_DISCONNECTED event for passt network device %s in domain %s - QEMU binary does not support reconnect",
-                  def->info.alias, vm->def->name);
-        goto endjob;
-    }
-
     /* handle the event - restart the passt process with its original
      * parameters
      */