media: qcom: venus: fix incorrect return value

'pd' can be NULL, and in that case it shouldn't be passed to
PTR_ERR. Fixes a smatch warning:

drivers/media/platform/qcom/venus/pm_helpers.c:873 vcodec_domains_get() warn: passing zero to 'PTR_ERR'

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_helpers.c
index 48c9084bb4dba82902ddd2b916f3e06e0a527434..a1b127caa90a763c10199108d6a1d1897712ab42 100644 (file)
--- a/drivers/media/platform/qcom/venus/pm_helpers.c
+++ b/drivers/media/platform/qcom/venus/pm_helpers.c
@@ -870,7 +870,7 @@ static int vcodec_domains_get(struct venus_core *core)
                pd = dev_pm_domain_attach_by_name(dev,
                                                  res->vcodec_pmdomains[i]);
                if (IS_ERR_OR_NULL(pd))
-                       return PTR_ERR(pd) ? : -ENODATA;
+                       return pd ? PTR_ERR(pd) : -ENODATA;
                core->pmdomains[i] = pd;
        }