]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: i2c: vgxy61: Use the v4l2 helper for obtaining the clock
authorMehdi Djait <mehdi.djait@linux.intel.com>
Thu, 26 Jun 2025 13:34:38 +0000 (15:34 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Wed, 13 Aug 2025 13:10:28 +0000 (15:10 +0200)
devm_clk_get() fails on ACPI-based platforms, where firmware does not
provide a direct reference to the clock producer.

Replace devm_clk_get() with the new v4l2 helper
devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based
platforms to retrieve a reference to the clock producer from firmware.

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/vgxy61.c

index 5b0479f3a3c0592be430cefe5a1ab9a76812ba84..3d001e0b646b4c613102322e04665a7a9954902e 100644 (file)
@@ -1761,11 +1761,11 @@ static int vgxy61_probe(struct i2c_client *client)
                return ret;
        }
 
-       sensor->xclk = devm_clk_get(dev, NULL);
-       if (IS_ERR(sensor->xclk)) {
-               dev_err(dev, "failed to get xclk\n");
-               return PTR_ERR(sensor->xclk);
-       }
+       sensor->xclk = devm_v4l2_sensor_clk_get(dev, NULL);
+       if (IS_ERR(sensor->xclk))
+               return dev_err_probe(dev, PTR_ERR(sensor->xclk),
+                                    "failed to get xclk\n");
+
        sensor->clk_freq = clk_get_rate(sensor->xclk);
        if (sensor->clk_freq < 6 * HZ_PER_MHZ ||
            sensor->clk_freq > 27 * HZ_PER_MHZ) {