sparse-checkout: free pattern list in sparse_checkout_list()

In sparse_checkout_list(), we create a pattern_list that needs to
eventually be cleared. We remember to do so in the regular code path,
but the cone-mode path does an early return, and forgets to clean up.

We could fix the leak by adding a new call to clear_pattern_list(). But
we can simplify even further by just skipping the early return, pushing
the other code path (which consists now of only one line!) into an else
block. That also matches the same cone/non-cone if/else used in some
other functions.

This fixes 15 leaks found in t1091.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/builtin/sparse-checkout.c b/builtin/sparse-checkout.c
index 79342480eb2ed7ed58908093994d5d24662c6d33..fb43bb7577144380a3669904485d2a6ed399dfd8 100644 (file)
--- a/builtin/sparse-checkout.c
+++ b/builtin/sparse-checkout.c
@@ -95,11 +95,10 @@ static int sparse_checkout_list(int argc, const char **argv, const char *prefix)
                        quote_c_style(sl.items[i].string, NULL, stdout, 0);
                        printf("\n");
                }
-
-               return 0;
+       } else {
+               write_patterns_to_file(stdout, &pl);
        }
 
-       write_patterns_to_file(stdout, &pl);
        clear_pattern_list(&pl);
 
        return 0;