]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
scsi: qla1280: Fix kernel oops when debug level > 2
authorMagnus Lindholm <linmag7@gmail.com>
Sat, 25 Jan 2025 09:49:22 +0000 (10:49 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 3 Feb 2025 22:54:56 +0000 (17:54 -0500)
A null dereference or oops exception will eventually occur when qla1280.c
driver is compiled with DEBUG_QLA1280 enabled and ql_debug_level > 2.  I
think its clear from the code that the intention here is sg_dma_len(s) not
length of sg_next(s) when printing the debug info.

Signed-off-by: Magnus Lindholm <linmag7@gmail.com>
Link: https://lore.kernel.org/r/20250125095033.26188-1-linmag7@gmail.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla1280.c

index 1fd2da0264e38b3c9d58ae42373adc748de11413..47d74f881948f44dacd4640710a4d248a12c3d0f 100644 (file)
@@ -2867,7 +2867,7 @@ qla1280_64bit_start_scsi(struct scsi_qla_host *ha, struct srb * sp)
                        dprintk(3, "S/G Segment phys_addr=%x %x, len=0x%x\n",
                                cpu_to_le32(upper_32_bits(dma_handle)),
                                cpu_to_le32(lower_32_bits(dma_handle)),
-                               cpu_to_le32(sg_dma_len(sg_next(s))));
+                               cpu_to_le32(sg_dma_len(s)));
                        remseg--;
                }
                dprintk(5, "qla1280_64bit_start_scsi: Scatter/gather "