]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
gdb/testsuite: handle long filenames in gdb.base/startup-with-shell.exp
authorAndrew Burgess <aburgess@redhat.com>
Wed, 17 Jan 2024 09:53:16 +0000 (09:53 +0000)
committerAndrew Burgess <aburgess@redhat.com>
Wed, 17 Jan 2024 15:33:47 +0000 (15:33 +0000)
I got a report of a failure from Linaro's CI testing for the test
gdb.base/startup-with-shell.exp.

Looking at the log I see this:

  (gdb) PASS: gdb.base/startup-with-shell.exp: startup_with_shell = on; run_args = *.unique-extension: inferior started
  print argv[1]
  $1 = 0xfffed978 "/home/tcwg-build/workspace/tcwg_gnu_4/abe/builds/armv8l-unknown-linux-gnueabihf/armv8l-unknown-linux-gnueabihf/gdb-gdb.git~master/gdb/testsuite/outputs/gdb.base/startup-with-shell/unique-file.unique-e"...
  (gdb) FAIL: gdb.base/startup-with-shell.exp: startup_with_shell = on; run_args = *.unique-extension: first argument expanded

Notice that the value of $1 was truncated (indicated by the trailing
ellipses), and as a result it isn't going to match the expected output
pattern.

Avoid this by adding a call to 'set print characters unlimited' which
allows GDB to print strings of any length.

Approved-By: Tom de Vries <tdevries@suse.de>
gdb/testsuite/gdb.base/startup-with-shell.exp

index b73d5d740f5fb229716079cffe7f2b03dd21c92c..d5ec503dceb77c79c7f998954f071efc1004e180 100644 (file)
@@ -59,6 +59,7 @@ proc initial_setup_simple { startup_with_shell run_args } {
 
 with_test_prefix "startup_with_shell = on; run_args = *.unique-extension" {
     initial_setup_simple "on" "$unique_file_dir/*.unique-extension"
+    gdb_test_no_output "set print characters unlimited"
     gdb_test "print argv\[1\]" "\\\$$decimal = $hex \"$unique_file\"" \
        "first argument expanded"
 }